fix s3 issue if deploying from region other than us-east-1 #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arief-hidayat , Thank you for the update! (and sorry for the late follow up) The use of That being said I don't see a downside of this change since v4 is the current version |
|
If I remember correctly, there is CORS issue because of the behaviour mentioned in the blog (about redirect URL). So, I followed the blog recommendation and it worked (at least tested on ap-southeast-3 case). I haven't tried removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
encounter S3 issue when deploying from ap-southeast-3 (other than us-east-1), such as CORS.
Description of changes:
follow recommendation from https://aws.amazon.com/blogs/media/deep-dive-into-cors-configs-on-aws-s3-how-to/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.